Consolidate lint and spec-lint into root check:all #289

New issue

Closed

opened 2026-06-05 12:25:43 +00:00 by steve · 0 comments

steve commented

2026-06-05 12:25:43 +00:00

Owner

Problem

Forgejo checks and local docker:ci-check run pnpm check:all and then
make spec-lint separately even though both are repo validation gates.
Package ESLint (pnpm lint) was not part of CI at all.

Goal

Make root check:all the single repo validation entry point for formatting,
types, ESLint, and spec markdown lint; update CI, docker:ci-check, release
verification, and docs to match.

Acceptance Criteria

Root check:all runs package ESLint, lint:root, and spec:lint
Turbo package check:all depends on lint
Forgejo checks and release-desktop workflows drop the separate spec-lint step
docker:ci-check and release-desktop-local mirror the consolidated flow
Spec/AGENTS docs describe the consolidated ladder

Validation Commands

pnpm test:scripts
pnpm check:all

Implementation Summary

Root check:all now runs package ESLint via Turbo, lint:root, and spec:lint. Turbo check:all depends on lint. Removed separate make spec-lint steps from checks.yml, release-desktop.yml, docker:ci-check, and release-desktop-local. Updated AGENTS.md, monorepo-scripts, release-management, and testing spec.

## Problem Forgejo checks and local docker:ci-check run `pnpm check:all` and then `make spec-lint` separately even though both are repo validation gates. Package ESLint (`pnpm lint`) was not part of CI at all. ## Goal Make root `check:all` the single repo validation entry point for formatting, types, ESLint, and spec markdown lint; update CI, docker:ci-check, release verification, and docs to match. ## Acceptance Criteria - [ ] Root `check:all` runs package ESLint, `lint:root`, and `spec:lint` - [ ] Turbo package `check:all` depends on `lint` - [ ] Forgejo checks and release-desktop workflows drop the separate spec-lint step - [ ] docker:ci-check and release-desktop-local mirror the consolidated flow - [ ] Spec/AGENTS docs describe the consolidated ladder ## Validation Commands - `pnpm test:scripts` - `pnpm check:all`  ## Implementation Summary Root check:all now runs package ESLint via Turbo, lint:root, and spec:lint. Turbo check:all depends on lint. Removed separate make spec-lint steps from checks.yml, release-desktop.yml, docker:ci-check, and release-desktop-local. Updated AGENTS.md, monorepo-scripts, release-management, and testing spec.

steve

2026-06-05 12:25:43 +00:00