Align Forgejo release-desktop CI verify with checks workflow #293

New issue

Closed

opened 2026-06-05 14:39:15 +00:00 by steve · 0 comments

steve commented

2026-06-05 14:39:15 +00:00

Owner

Describe the issue.

Problem

release-desktop.yml verify passed pnpm check:all and smoke tests but omitted
the checks.yml resource profile (TURBO_CONCURRENCY, NODE_OPTIONS,
LAPIS_SMOKE_DESKTOP_FULL_BUILD) and the pnpm test gate, causing Electron
smoke failures under CI load.

Goal

Share one Forgejo verification path between checks.yml and release workflows.

Scope

Composite actions for CI job env and verification steps
checks.yml, release-desktop.yml, plugin-assets, and lapis.md publish jobs
Spec updates for release management and monorepo scripts

Non-goals

Changing macOS build job setup
publish-spec.yml (no Turbo/smoke path)

Acceptance Criteria

release-desktop verify runs the same steps/env as checks.yml
Turbo-heavy lapis-ci jobs apply the shared job env action
Spec documents the shared actions

Implementation Notes

Extract .github/actions/lapis-ci-job-env and .github/actions/lapis-ci-verify
from the stabilized checks.yml profile added in #279.

Suggested Files or Specs To Inspect

.forgejo/workflows/checks.yml
.forgejo/workflows/release-desktop.yml
.github/actions/lapis-ci-job-env/action.yml
.github/actions/lapis-ci-verify/action.yml

Validation Commands

node --test scripts/run-lapis-ci-check.test.mjs
pnpm spec:lint

Follow-up to #279 — Stabilize plugin-manager install-bundle tests under CI load

Follow-up Tasks

Implementation Summary

Extracted shared Forgejo composite actions lapis-ci-job-env and lapis-ci-verify from checks.yml, wired release-desktop verify to the same path (adding missing pnpm test and CI resource env), and applied job env to build-linux plus plugin-assets and lapis.md publish jobs. Updated release-management and monorepo-scripts specs; added run-lapis-ci-check.test.mjs guard for action parity.

Describe the issue. ## Problem `release-desktop.yml` `verify` passed `pnpm check:all` and smoke tests but omitted the `checks.yml` resource profile (`TURBO_CONCURRENCY`, `NODE_OPTIONS`, `LAPIS_SMOKE_DESKTOP_FULL_BUILD`) and the `pnpm test` gate, causing Electron smoke failures under CI load. ## Goal Share one Forgejo verification path between `checks.yml` and release workflows. ## Scope - Composite actions for CI job env and verification steps - `checks.yml`, `release-desktop.yml`, plugin-assets, and lapis.md publish jobs - Spec updates for release management and monorepo scripts ## Non-goals - Changing macOS build job setup - publish-spec.yml (no Turbo/smoke path) ## Acceptance Criteria - `release-desktop` `verify` runs the same steps/env as `checks.yml` - Turbo-heavy lapis-ci jobs apply the shared job env action - Spec documents the shared actions ## Implementation Notes Extract `.github/actions/lapis-ci-job-env` and `.github/actions/lapis-ci-verify` from the stabilized `checks.yml` profile added in #279. ## Suggested Files or Specs To Inspect - `.forgejo/workflows/checks.yml` - `.forgejo/workflows/release-desktop.yml` - `.github/actions/lapis-ci-job-env/action.yml` - `.github/actions/lapis-ci-verify/action.yml` ## Validation Commands - `node --test scripts/run-lapis-ci-check.test.mjs` - `pnpm spec:lint` ## Related Issues - Follow-up to #279 — [Stabilize plugin-manager install-bundle tests under CI load](../closed/279-stabilize-plugin-manager-install-bundle-tests-under-ci-load.md) ## Follow-up Tasks ## Implementation Summary Extracted shared Forgejo composite actions lapis-ci-job-env and lapis-ci-verify from checks.yml, wired release-desktop verify to the same path (adding missing pnpm test and CI resource env), and applied job env to build-linux plus plugin-assets and lapis.md publish jobs. Updated release-management and monorepo-scripts specs; added run-lapis-ci-check.test.mjs guard for action parity.

steve

2026-06-05 14:39:15 +00:00