Fix Forgejo release-desktop macOS AppImage hook and artifact upload v3 #307

New issue

Closed

opened 2026-06-05 19:10:44 +00:00 by steve · 0 comments

steve commented

2026-06-05 19:10:44 +00:00

Owner

Forgejo release-desktop macOS and Linux build jobs fail after recent AppImage normalization and artifact upload changes.

Problem

build-macos fails in afterAllArtifactBuild because normalizeLinuxAppImageArtifact throws when no Linux AppImage exists on mac-only builds.
build-linux fails uploading workflow artifacts because Forgejo does not support upload-artifact@v4 / @actions/artifact v2+.

Goal

Restore green macOS and Linux desktop release builds on Forgejo.

Scope

Skip Linux AppImage normalization in electron-builder when the release directory has no AppImage.
Downgrade Forgejo release-desktop workflow artifact upload/download to v3-compatible actions.

Non-goals

Changing GitHub mirror workflows that can keep v4.
Reworking publish-release asset expectations for skipped build toggles.

Acceptance Criteria

macOS electron-builder runs complete without requiring a Linux AppImage in release/.
Linux and macOS build jobs upload workflow artifacts on Forgejo without GHESNotSupportedError.
publish-release can download and combine Linux and macOS artifacts with v3 actions.

Implementation Notes

Gate afterAllArtifactBuild on presence of .AppImage files. Use actions/upload-artifact@v3 and actions/download-artifact@v3 in .forgejo/workflows/release-desktop.yml; download platform artifacts into the shared release-artifacts/ directory in separate conditional steps.

Suggested Files or Specs To Inspect

packages/desktop-electron/electron-builder.config.cjs
.forgejo/workflows/release-desktop.yml
spec/src/80-maintenance/release-management.md

Validation Commands

pnpm test:scripts
pnpm --filter @lapis-notes/desktop-electron check:all (if applicable)

Follow-up Tasks

Implementation Summary

Gated electron-builder afterAllArtifactBuild AppImage normalization on presence of .AppImage files so macOS-only builds succeed. Downgraded Forgejo release-desktop workflow artifact upload/download to actions/upload-artifact@v3 and download-artifact@v3 with per-platform download steps. Updated release-management spec. Validated with pnpm test:scripts and pnpm spec:lint.

Forgejo `release-desktop` macOS and Linux build jobs fail after recent AppImage normalization and artifact upload changes. ## Problem - `build-macos` fails in `afterAllArtifactBuild` because `normalizeLinuxAppImageArtifact` throws when no Linux AppImage exists on mac-only builds. - `build-linux` fails uploading workflow artifacts because Forgejo does not support `upload-artifact@v4` / `@actions/artifact` v2+. ## Goal Restore green macOS and Linux desktop release builds on Forgejo. ## Scope - Skip Linux AppImage normalization in electron-builder when the release directory has no AppImage. - Downgrade Forgejo release-desktop workflow artifact upload/download to v3-compatible actions. ## Non-goals - Changing GitHub mirror workflows that can keep v4. - Reworking publish-release asset expectations for skipped build toggles. ## Acceptance Criteria - macOS electron-builder runs complete without requiring a Linux AppImage in `release/`. - Linux and macOS build jobs upload workflow artifacts on Forgejo without GHESNotSupportedError. - `publish-release` can download and combine Linux and macOS artifacts with v3 actions. ## Implementation Notes Gate `afterAllArtifactBuild` on presence of `.AppImage` files. Use `actions/upload-artifact@v3` and `actions/download-artifact@v3` in `.forgejo/workflows/release-desktop.yml`; download platform artifacts into the shared `release-artifacts/` directory in separate conditional steps. ## Suggested Files or Specs To Inspect - `packages/desktop-electron/electron-builder.config.cjs` - `.forgejo/workflows/release-desktop.yml` - `spec/src/80-maintenance/release-management.md` ## Validation Commands - `pnpm test:scripts` - `pnpm --filter @lapis-notes/desktop-electron check:all` (if applicable) ## Related Issues ## Follow-up Tasks ## Implementation Summary Gated electron-builder afterAllArtifactBuild AppImage normalization on presence of .AppImage files so macOS-only builds succeed. Downgraded Forgejo release-desktop workflow artifact upload/download to actions/upload-artifact@v3 and download-artifact@v3 with per-platform download steps. Updated release-management spec. Validated with pnpm test:scripts and pnpm spec:lint.

steve

2026-06-05 19:10:44 +00:00