Make package check:all run static checks and separate test #335

New issue

Closed

opened 2026-06-06 10:20:29 +00:00 by steve · 0 comments

steve commented

2026-06-06 10:20:29 +00:00

Owner

Problem

Package check:all was a no-op in most packages (node -e "process.exit(0)").
Real static checks only ran when invoked through root turbo run check:all.
Direct pnpm --filter <pkg> check:all (documented in AGENTS.md) exited
immediately without running format, svelte, types, or lint.

Some packages also ran tests inside check:all (ui, docs, markdown-lint,
workspace check:unit).

Goal

Make package check:all run static checks locally. Keep tests on pnpm test
only. Update agent docs to require both check:all and test on modified
packages.

Acceptance Criteria

Shared scripts/run-package-check-all.mjs runs defined static checks in order
All workspace packages point check:all at the helper; no test scripts in check:all
Turbo check:all no longer duplicates subtasks via dependsOn
AGENTS.md and monorepo-scripts document check:all + test per modified package
pnpm test:scripts and repo-root pnpm check:all pass

Validation Commands

pnpm test:scripts
pnpm --filter @lapis-notes/api check:all
pnpm check:all

Implementation Summary

Added scripts/run-package-check-all.mjs so package check:all runs static checks (format, svelte, types, astro/e2e/prepare, lint) and never tests. Updated all workspace package.json files, simplified turbo.json check:all, and documented check:all + test per modified package in AGENTS.md and spec. Validated with pnpm test:scripts and pnpm check:all.

## Problem Package `check:all` was a no-op in most packages (`node -e "process.exit(0)"`). Real static checks only ran when invoked through root `turbo run check:all`. Direct `pnpm --filter <pkg> check:all` (documented in AGENTS.md) exited immediately without running format, svelte, types, or lint. Some packages also ran tests inside `check:all` (ui, docs, markdown-lint, workspace check:unit). ## Goal Make package `check:all` run static checks locally. Keep tests on `pnpm test` only. Update agent docs to require both `check:all` and `test` on modified packages. ## Acceptance Criteria - [x] Shared `scripts/run-package-check-all.mjs` runs defined static checks in order - [x] All workspace packages point `check:all` at the helper; no test scripts in `check:all` - [x] Turbo `check:all` no longer duplicates subtasks via `dependsOn` - [x] AGENTS.md and monorepo-scripts document check:all + test per modified package - [x] `pnpm test:scripts` and repo-root `pnpm check:all` pass ## Validation Commands - `pnpm test:scripts` - `pnpm --filter @lapis-notes/api check:all` - `pnpm check:all`  ## Implementation Summary Added scripts/run-package-check-all.mjs so package check:all runs static checks (format, svelte, types, astro/e2e/prepare, lint) and never tests. Updated all workspace package.json files, simplified turbo.json check:all, and documented check:all + test per modified package in AGENTS.md and spec. Validated with pnpm test:scripts and pnpm check:all.

steve

2026-06-06 10:20:29 +00:00